Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guide for #9718 #10578

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Nov 22, 2024

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • no Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Thanks to the excellent doc contribution by @ulidtko in #10559.

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 22, 2024

Does this need a backport? Or do we always link master for changelogs?

PR haskell#9718 and related PRs reshuffled and refactored Cabal API.
This patch adds a simple migration guide for Cabal library
users.

Authored-by: Maxim Ivanov
@ffaf1 ffaf1 force-pushed the breaking-changes-3.14 branch from 7614e7c to b4c1f10 Compare November 22, 2024 08:49
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Nov 22, 2024

Check commit by commit, GitHub rich diff gets confused and messes the diff up.

@ffaf1 ffaf1 marked this pull request as ready for review November 22, 2024 08:51
Copy link
Contributor

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nitpick

release-notes/Cabal-3.14.0.0.md Outdated Show resolved Hide resolved
Co-authored-by: Maxim Ivanov <ulidtko@gmail.com>
@ulysses4ever
Copy link
Collaborator

Does this need a backport? Or do we always link master for changelogs?

Only master, yes.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific! Thanks Francesco and Maxim!

@ffaf1 ffaf1 added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Nov 22, 2024
@mpickering
Copy link
Collaborator

Thanks for contributing this @ulidtko

@ffaf1 ffaf1 linked an issue Nov 23, 2024 that may be closed by this pull request
@ulidtko
Copy link
Contributor

ulidtko commented Nov 30, 2024

Ping @ulysses4ever, @Kleidukos, merge any soon?

@ulysses4ever
Copy link
Collaborator

@ulidtko, thanks for the ping! The funny thing is, despite overwhelming support, we still lack the second review. Maybe @geekosaur?..

@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Nov 30, 2024
@mergify mergify bot merged commit 3917567 into haskell:master Nov 30, 2024
14 checks passed
@ffaf1 ffaf1 deleted the breaking-changes-3.14 branch November 30, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cabal library API breakage in 3.14.0.0
5 participants